History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CASTOR-1033
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Martin Fuchs
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.

Compiler Warnings

Created: 02/Mar/05 12:30 AM   Updated: 04/Aug/05 03:14 AM
Component/s: General
Affects Version/s: 0.9.6
Fix Version/s: 0.9.7 M1

Time Tracking:
Not Specified

File Attachments: 1. Text File 1896.patch (315 kb)
2. Text File 1896.patch (274 kb)

Operating System: Windows XP
Platform: PC

 Description  « Hide
Eclipse reports a lot of warnings for the whole Castor source code. I will
create a patch, that eliminates most of them. (without changing any

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Keith Visco - 02/Mar/05 10:10 AM
Hi Martin,

I agree with this in general as I'm using Eclipse also and see all the warnings,
but I'm in the middle of making a number of changes to the XML side of the show
and have been cleaning up all the compiler warnings on the files I'm touching.
If you can hold off on touching the castor.xml package that would be great and
I'll do that package myself as I continue to plug along. I'm always weary of CVS
updates when I have a lot of changes in my branch.



Martin Fuchs - 02/Mar/05 12:28 PM
OK, I won't change the XML package. I see there are many unused imports in
classes marked by "This class was automatically generated with ... using an XML
Schema." Do you think, we should also include this classes in the patch? When
re-generating the warnings will be back again?

Martin Fuchs - 02/Mar/05 02:47 PM
Created an attachment (id=946)
proposed patch

OK, this is the patch containing various fixes against compiler warning
messages, Java doc corrections, and also some white space fixes.

Martin Fuchs - 02/Mar/05 02:52 PM
What do you think about this changes - can I go on and commit them? (of course
also adding an entry in the CHANGELOG file)
The XML packages are not touched, so Keith should not see CVS conflicts.
There are not all warnings fixed. Some are really warnings to investigate
further - there may be some problems they point to. But that's what warnings
are made for.

Keith Visco - 02/Mar/05 07:27 PM

We should make it such that generated classes don't have any warnings as well.
So that's something I need to fix in the source generator is to try and not
import classes that are not always used. That way even if we re-generate the
source code we won't get a lot of warnings.


Ralf Joachim - 03/Mar/05 02:38 AM
I very much appreciate this patch and promis to check it during the next days
and if there are no great problems I'll vote to commit this a.s.a.p.

Werner Guttmann - 03/Mar/05 02:43 AM
Cool. Now, if I remeber correctly, Martin has been made a committer a couple of
weeks ago, too. Now don't start fighting on who's going to be assigned .. .

Martin Fuchs - 03/Mar/05 02:44 PM
There are some problems with CastorSourceGenTask.java. May be, it was imported
with MAC encoding and CVS didn't understand this correctly.
I will remove this file from the patch.

Martin Fuchs - 03/Mar/05 03:14 PM
Created an attachment (id=951)
proposed patch

This is the updated patch without the two problematic files
(CastorSourceGenTask.java, Messages.java), and now also including fixes for
unused import statements in Castor generated source code files.

Werner Guttmann - 04/Mar/05 01:21 AM
+1. And don't forget to set the state of this bug to 'accepted' ... .

Ralf Joachim - 04/Mar/05 01:31 PM
Martin you did a fantastic work. Get a ++++++ from my side

Martin Fuchs - 05/Mar/05 05:43 AM
Thanks, Ralf.

Now we are only waiting for Keith to clean up his workspace and eliminate the
remaining unnecessary XML code warnings.

Werner Guttmann - 05/Mar/05 12:26 PM
Keith, do you want me to create a new bug report (aka reminder) for the fixes
you mentioned with regards to the source generator ?