|
|
|
OK, I won't change the XML package. I see there are many unused imports in
classes marked by "This class was automatically generated with ... using an XML Schema." Do you think, we should also include this classes in the patch? When re-generating the warnings will be back again? Created an attachment (id=946)
proposed patch OK, this is the patch containing various fixes against compiler warning What do you think about this changes - can I go on and commit them? (of course
also adding an entry in the CHANGELOG file) The XML packages are not touched, so Keith should not see CVS conflicts. There are not all warnings fixed. Some are really warnings to investigate further - there may be some problems they point to. But that's what warnings are made for. ![]() Martin,
We should make it such that generated classes don't have any warnings as well. --Keith I very much appreciate this patch and promis to check it during the next days
and if there are no great problems I'll vote to commit this a.s.a.p. Cool. Now, if I remeber correctly, Martin has been made a committer a couple of
weeks ago, too. Now don't start fighting on who's going to be assigned .. ![]() There are some problems with CastorSourceGenTask.java. May be, it was imported
with MAC encoding and CVS didn't understand this correctly. I will remove this file from the patch. Created an attachment (id=951)
proposed patch This is the updated patch without the two problematic files +1. And don't forget to set the state of this bug to 'accepted' ...
![]() Martin you did a fantastic work. Get a ++++++ from my side
Thanks, Ralf.
Now we are only waiting for Keith to clean up his workspace and eliminate the Keith, do you want me to create a new bug report (aka reminder) for the fixes
you mentioned with regards to the source generator ? |
I agree with this in general as I'm using Eclipse also and see all the warnings,
but I'm in the middle of making a number of changes to the XML side of the show
and have been cleaning up all the compiler warnings on the files I'm touching.
If you can hold off on touching the castor.xml package that would be great and
I'll do that package myself as I continue to plug along. I'm always weary of CVS
updates when I have a lot of changes in my branch.
Thanks,
--Keith