History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CASTOR-929
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Werner Guttmann
Reporter: Martin Fuchs
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.

fix bind parameter order handling

Created: 13/Nov/04 10:28 AM   Updated: 19/Apr/05 10:53 AM
Component/s: JDO
Affects Version/s:
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments: 1. Text File castor-1792-neu.patch (11 kb)
2. Text File castor-1792.patch (23 kb)

Operating System: All
Platform: All

Bugzilla Id: 1792

 Description  « Hide
While writing the OQL test cases I encountered another problem introduced by
the LIMIT/OFFSET changes. The attached patch fixes this errors by removing the
old bind parameter map. Handling of bind parameter order is now completely
handled by SqlBindParser - there's no need for ParamInfo to know about this

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Martin Fuchs - 13/Nov/04 10:29 AM
Created an attachment (id=772)
proposed patch including CTF tests for basic OQL queries

Werner Guttmann - 19/Nov/04 12:33 PM
How does/did the problem manifest itself ?

Martin Fuchs - 19/Nov/04 03:14 PM
The problem shows up, if you execute queries like "... where id between $2 and
$1": If the bind variables are not used in ascending order, their values are
used in the wrong order. ("... between $1 and $2" in this case"

Werner Guttmann - 22/Nov/04 03:29 AM
Martin, your patch includes code that has been posted as part of bug 1788. Can
you please remove this from and repost the patch ?

Martin Fuchs - 22/Nov/04 11:54 AM
Well, I didn't know, which of the bug reports you would process first, so they
contain partially the same test cases. Let's wait until after commiting of bug
1788, and then separate the two patches.

Werner Guttmann - 22/Nov/04 01:28 PM
Bug 1788 has been committed. Time for a spring-time cleaning session .. .

Werner Guttmann - 26/Nov/04 03:45 AM
Just marking this bug (eventually) as fixed .. .

Werner Guttmann - 26/Nov/04 03:47 AM
Martin, a fresh patch would be something absolutely tasty .. .

Martin Fuchs - 26/Nov/04 02:07 PM
Created an attachment (id=789)
updated patch

OK, here is the patch without the already committed parts.
It also removes the testSelectWithLimitClause() test function, as there is a
complete test case for the LIMIT keyword.

Werner Guttmann - 28/Nov/04 06:01 AM
Patch applied as discussed.

Werner Guttmann - 28/Nov/04 06:01 AM
And now with setting the state of this bug to 'fixed' .. ;-(.

Martin Fuchs - 28/Nov/04 06:28 AM
OK, verified and closed.