Query page
Enter new bug
Eclipse reports a lot of warnings for the whole Castor source code. I will
create a patch, that eliminates most of them. (without changing any
functionality)
------- Additional Comment
#1 From
Keith Visco
2005-03-02 10:10 -------
Hi Martin,
I agree with this in general as I'm using Eclipse also and see all the warnings,
but I'm in the middle of making a number of changes to the XML side of the show
and have been cleaning up all the compiler warnings on the files I'm touching.
If you can hold off on touching the castor.xml package that would be great and
I'll do that package myself as I continue to plug along. I'm always weary of CVS
updates when I have a lot of changes in my branch.
Thanks,
--Keith
------- Additional Comment
#2 From
Martin Fuchs
2005-03-02 12:28 -------
OK, I won't change the XML package. I see there are many unused imports in
classes marked by "This class was automatically generated with ... using an XML
Schema." Do you think, we should also include this classes in the patch? When
re-generating the warnings will be back again?
------- Additional Comment
#3 From
Martin Fuchs
2005-03-02 14:47 -------
Created an attachment (id=946)
proposed patch
OK, this is the patch containing various fixes against compiler warning
messages, Java doc corrections, and also some white space fixes.
------- Additional Comment
#4 From
Martin Fuchs
2005-03-02 14:52 -------
What do you think about this changes - can I go on and commit them? (of course
also adding an entry in the CHANGELOG file)
The XML packages are not touched, so Keith should not see CVS conflicts.
There are not all warnings fixed. Some are really warnings to investigate
further - there may be some problems they point to. But that's what warnings
are made for. :)
------- Additional Comment
#5 From
Keith Visco
2005-03-02 19:27 -------
Martin,
We should make it such that generated classes don't have any warnings as well.
So that's something I need to fix in the source generator is to try and not
import classes that are not always used. That way even if we re-generate the
source code we won't get a lot of warnings.
--Keith
------- Additional Comment
#6 From
ralf joachim
2005-03-03 02:38 -------
I very much appreciate this patch and promis to check it during the next days
and if there are no great problems I'll vote to commit this a.s.a.p.
------- Additional Comment
#7 From
Werner Guttmann
2005-03-03 02:43 -------
Cool. Now, if I remeber correctly, Martin has been made a committer a couple of
weeks ago, too. Now don't start fighting on who's going to be assigned .. ;-).
------- Additional Comment
#8 From
Martin Fuchs
2005-03-03 14:44 -------
There are some problems with CastorSourceGenTask.java. May be, it was imported
with MAC encoding and CVS didn't understand this correctly.
I will remove this file from the patch.
------- Additional Comment
#9 From
Martin Fuchs
2005-03-03 15:14 -------
Created an attachment (id=951)
proposed patch
This is the updated patch without the two problematic files
(CastorSourceGenTask.java, Messages.java), and now also including fixes for
unused import statements in Castor generated source code files.
------- Additional Comment
#10 From
Werner Guttmann
2005-03-04 01:21 -------
+1. And don't forget to set the state of this bug to 'accepted' ... ;-).
------- Additional Comment
#11 From
ralf joachim
2005-03-04 13:31 -------
Martin you did a fantastic work. Get a ++++++ from my side
------- Additional Comment
#12 From
Martin Fuchs
2005-03-05 05:43 -------
Thanks, Ralf.
Now we are only waiting for Keith to clean up his workspace and eliminate the
remaining unnecessary XML code warnings. ;-)
------- Additional Comment
#13 From
Werner Guttmann
2005-03-05 12:26 -------
Keith, do you want me to create a new bug report (aka reminder) for the fixes
you mentioned with regards to the source generator ?
Query page
Enter new bug
This is Bugzilla: the Mozilla bug system. For more
information about what Bugzilla is and what it can do, see
bugzilla.org.
|
|