|
|
|
Martin, your patch above does not overload getStatement (boolean) as in all the
other QueryExpression instances .. ![]() 1732, and add the code myself. Please ignore my last comment, figured things out myself the hard way ... ;-(.
Sorry, I thought you did know, the LIMIT code was already present in
SQLServerQueryExpression. It was just no more active since the introduction of isLimitClauseSupported(). Well, this problem had been catched far sooner. What's missing in this project
is running the test suite for ALL databases on a regular base. This could be achieved by setting up a test server running an instance of any DB and launching the tests using a batch job. But there's of course some work to be done for this... ![]() No problem, Martin. As long as I can keep the overhead cycles to a minimum, I
am fine .. ![]() Let's see what Bruce has got to say to the 'test server' issue, though he's not I'm happy to test against SQL Server. I'll check out a fresh copy of Castor,
apply the patch and run the test suite to see if it passes. I have all of this set up in SQL Server already. Hi Patrick,
can you please also try to run text case TC62 for MS SQL using the following Index: src/tests/tests.xml </harness> Index: src/tests/jdo/TestLimitClause.java public void runTest() throws PersistenceException { testLimit(); +/* no support for OFFSET with MS SQL Server testLimitWithOffset(); +*/ testOffsetWithoutLimit(); } Thanks. Actually, looking at this, I believe that TestLimit should be split into two
classes, TestLimit and TestLimitOffset in suich a way that a) testLimit() should remain in TestLimit This way, we could selectively include one or the other CTF test case in So I agree. Splitting the test case would allow to test LIMIT for MS SQL
without getting the "OFFSET not supported" exception. <comment> Created an attachment (id=706)
Complete patch (for review) Above patch includes the changes to SQLServerQueryExpression as discussed, plus
the change to src/tests/jdo/TestLimitClause. This change introduces a new class src/tests/jdo/TestLimitWithOffsetClause that extends TestLimitClause, and moves all test methods related to testing LIMIT with OFFSET clauses to the former. In addition, I've patched src/tests/tests.xml to use one or the other, wherever appropriate. The patch looks good. Just waiting for Patrick's test results.
![]() ooops... am on it. Got swamped in client work!
I can confirm that if you modify SQLServerQueryExpression and TestLimitClause to
remove the offset (i.e. only run the testLimit() method) this runs successfully against SQL Server 2000 with the InetSoft Opta2000 driver. Unfortunately as a consequence of the fact that I haven’t run the suite against MSSQL for ages there are 2 other failures not related to this functionality. One of them appears to be schema change related but another needs to be examined further. Also, does anyone know of a Windows version of patch? I had to make all the > Unfortunately as a consequence of the fact that I haven’t run the
> suite against MSSQL for ages there are 2 other failures not related > to this functionality. What version numbers. TC02 fails with any RDBMS, and we are not going to get ths fixed any time soon .. ![]() > Also, does anyone know of a Windows version of patch?
Not really, but there's a choice. A fully-fledged IDE (such as Eclipse is), WinCVS, etc. Yes, TCO2 is one. Phew. I will double check the other schema-related problem and
file a patch in bugzilla if necessary. Looks like I need to finally take the Eclipse plunge as I use TortoiseCVS and it doesn't seem to play nice with WinCVS. > Looks like I need to finally take the Eclipse plunge as I use TortoiseCVS
> and it doesn't seem to play nice with WinCVS. Which is quite a surprise, as CVS is CVS, and diffs are diffs. Once Martin et alias start supplying unified diffs only, things should not be painful at all. What problems are you experiencing, iima ? Patrick, you may have a look at my WIN32 version of Linux tools I compiled some
time ago: http://private.addcom.de/m.fuchs/ftp/xtools.rar ![]() It includes a patch.exe you can use on Windows. Werner - WinCVS freezes on load after I installed TortoiseCVS, that's all... not
a patch file compat issue. Martin - Cheers, will download your tools. I think that the CVS support within Eclipse is one of the best I've seen so far.
And they are still adding new features as we speak (see the release notes for the 3.1M2 build, where they are introducing CVS commit sets for your convenience). Patrick, I know that switching to a new IDE is always work, but imho it pays off. And finally, did you eventually find some time to run the tests on MS SQL server ? I'm always getting the error message "I HATE YOU" from the exolab CVS server
when trying to connect using Eclipse. May be this is because I am using the anonymous CVS account? Well, the CVS integration in Eclipse is really quite good. basic commands > I'm always getting the error message "I HATE YOU" from the exolab CVS
> server when trying to connect using Eclipse. Eclipse 3.0 did have some problems with this before the M9 build. Bear in mind that Eclipse by default does not save your CVS password .. if you happen to have one. But as you are using anonymous access, I wonder what else it could be. It's just the same with Eclipse versions 3.0.0 and 3.1.0. May be Bruce can give
me a password to verify if the anoncvs is really causing the problem. ![]() Using cvs from the command line or using WinCVS just works without any problems. I made the changes indicated in the test manually and the new tests ran fine
against SQL Server, with the exception of TC02 as previously discussed. My main resistance to Eclipse is the performance of my laptop ![]() Martin, I tried xtools but seem to have a missing DLL (win32gnu.dll) - this Ooops - yes, this DLL is missing in the archive. I will send it to you in
private email and maybe update the archive. Gregory, thanks for the hint. It now works.
![]() ... and sorry for the off topic thread. I think we can now commit the patch, and close this bug, since the test was Committed as supplied above. In addition, I have moved all test methods
regarding the use of the OFFSET clause to a new TestLimitWithOffsetClause (TC62a), and modified to use this new class for MS SQL server (as it does not provide support for OFFSET clauses). |
Patch for SQLServerQueryExpression